Stop using GPP if WP is used #676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Have you checked golden affected workflows without dry-run? |
jamOne-
requested changes
Oct 8, 2025
Collaborator
jamOne-
left a comment
jamOne-
left a comment
There was a problem hiding this comment.
Should we now have at least one golden for an older tpu version?
Collaborator
Author
Cluster private is using v5 and it retains this flag |
Collaborator
Author
Not yet, I am trying now on staging, but if GKE team confirms this is enough we can merge even without a real run IMO |
jamOne-
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workload policy and group placement policy are mutually exclusive and since for TPUv7x we create WP we should avoid enabling GPP as well
Workload policy created:
(.venv) [hi on] feidias@feidias:~/xpk$ gcloud compute resource-policies describe xpk-gce-staging-test-placement-policy --project=$PROJECT --region=us-central2
creationTimestamp: '2025-10-08T07:50:39.713-07:00'
id: '8186090670030308560'
kind: compute#resourcePolicy
name: xpk-gce-staging-test-placement-policy
region: https://www.googleapis.com/compute/staging_beta/projects/gke-gcestg-vmqual-a-15/regions/us-central2
selfLink: https://www.googleapis.com/compute/staging_beta/projects/gke-gcestg-vmqual-a-15/regions/us-central2/resourcePolicies/xpk-gce-staging-test-placement-policy
status: READY
workloadPolicy:
acceleratorTopology: 2x2x1
type: HIGH_THROUGHPUT