Skip to content

Conversation

@scaliby
Copy link
Member

@scaliby scaliby commented Oct 13, 2025

Fixes / Features

Fixes command execution when running $ xpk.
Previously this was throwing:

AttributeError: 'Namespace' object has no attribute 'dry_run'

Now it works.

Copy link
Collaborator

@jamOne- jamOne- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Why doesn't it fail on skip_validation?
  2. Curious: what's the output of $ xpk?

@scaliby
Copy link
Member Author

scaliby commented Oct 13, 2025

  1. Why doesn't it fail on skip_validation?
  2. Curious: what's the output of $ xpk?
  1. main_args is an empty object when there is no subcommand. I changed to is_dry_run() per what @FIoannides said and it actually started to fail on skip_validation. I reorganized this code a bit so it handles all cases.
  2. it throws AttributeError, as in description.

@scaliby scaliby requested a review from jamOne- October 13, 2025 14:04
@jamOne-
Copy link
Collaborator

jamOne- commented Oct 13, 2025

I mean, what's the output of xpk after the changes?

@scaliby
Copy link
Member Author

scaliby commented Oct 14, 2025

I mean, what's the output of xpk after the changes?

It's the help page

@scaliby scaliby enabled auto-merge (squash) October 14, 2025 07:53
@scaliby scaliby merged commit bad6640 into develop Oct 14, 2025
12 checks passed
@scaliby scaliby deleted the scaliby/fix-plain-xpk-exec branch October 14, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants