Skip to content

Conversation

@scaliby
Copy link
Member

@scaliby scaliby commented Oct 21, 2025

Fixes / Features

Adds subslicing workload annotations necessary for the feature to work.

Testing / Documentation

Added a temporary print and this is the generated yaml:

template:
  metadata:
    labels:
      xpk.google.com/workload: workload
    annotations:
      
      kueue.x-k8s.io/podset-required-topology: "google.com/gke-tpu-slice-10x10-id"
      cloud.google.com/gke-tpu-slice-topology: 10x10
  spec:
    schedulerName: default-scheduler
    imagePullSecrets:
    - name: None
    restartPolicy: Never
    
    nodeSelector:
      cloud.google.com/gke-tpu-accelerator: tpu-v6e-slice
      cloud.google.com/gke-tpu-topology: 2x4
      
    priorityClassName: medium
    hostNetwork: true
    dnsPolicy: ClusterFirstWithHostNet

Experiment disabled:

          template:
            metadata:
              labels:
                xpk.google.com/workload: workload
              annotations:
                
                
            spec:
              schedulerName: default-scheduler
              imagePullSecrets:
              - name: None
              restartPolicy: Never
              
              nodeSelector:
                cloud.google.com/gke-tpu-accelerator: tpu-v6e-slice
                cloud.google.com/gke-tpu-topology: 2x4
                
              priorityClassName: medium
              hostNetwork: true
              dnsPolicy: ClusterFirstWithHostNet
              terminationGracePeriodSeconds: 30

the golden hash has changed because I added a new line in annotations section to yaml.

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@scaliby scaliby marked this pull request as ready for review October 21, 2025 15:28
@scaliby scaliby added the release-features features label Oct 21, 2025
@scaliby scaliby enabled auto-merge (squash) October 22, 2025 08:35
@scaliby scaliby merged commit b1ccea4 into AI-Hypercomputer:develop Oct 22, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants