Skip to content

Use get_topology_product instead of calculating topology product #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2025
Merged

Use get_topology_product instead of calculating topology product #713

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
374e726
feat: use get_topology_product instead of calculating topology produc…
scaliby Oct 21, 2025
5350fa5
Merge branch 'develop' into use-get_topology_product
scaliby Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/xpk/core/system_characteristics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@
"""

from dataclasses import dataclass
from functools import reduce
from operator import mul
from ..utils.topology import get_topology_product


AcceleratorType = {'TPU': 1, 'GPU': 2, 'CPU': 3}

Expand Down Expand Up @@ -135,7 +135,7 @@ def get_tpu_system_characteristics_map(
) -> dict[str, SystemCharacteristics]:
system_characteristics_map = {}
for topology in supported_topologies:
total_chips = reduce(mul, (int(x) for x in topology.split('x')), 1)
total_chips = get_topology_product(topology)
num_tensorcores = total_chips * tensorcores_per_chip
chips_per_vm = 1 if total_chips == 1 else 4
vms_per_slice = total_chips // chips_per_vm
Expand Down
Loading