Dynamic vms_per_slice computation for subslicing #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaliby
force-pushed
the
dynamic-vms_per_slice-computation
branch
from
e037b75 to
288b0c8
Compare
jamOne-
requested changes
Oct 22, 2025
scaliby
force-pushed
the
dynamic-vms_per_slice-computation
branch
from
288b0c8 to
ced6074
Compare
jamOne-
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / Features
Dynamic vms_per_slice computation for subslicing. This dynamically computed value can be supplied then into parallelism and completions.
Testing / Documentation
Code covered with goldens. The only change in goldens is applied kubectl yaml as we have changed comment there.
Note: this will pass tests after #717 is merged.