Skip to content

Conversation

@SikaGrr
Copy link
Collaborator

@SikaGrr SikaGrr commented Nov 10, 2025

Reverts #812

Revert requested to unblock MaxText benchmarks until they migrate to pip installed version.

@github-actions
Copy link

🤖 Hi @SikaGrr, I've received your request, and I'm working on it now! You can track my progress in the logs for more details.

@scaliby
Copy link
Member

scaliby commented Nov 10, 2025

This will break the telemetry background script launching. Can they checkout an older commit if they have a deprecated system? They should rely on fixed versions rather than disallowing us to make changes on HEAD.

git clone https://github.com/AI-Hypercomputer/xpk.git
git checkout v0.13.0

@SikaGrr
Copy link
Collaborator Author

SikaGrr commented Nov 10, 2025

This will break the telemetry background script launching. Can they checkout an older commit if they have a deprecated system? They should rely on fixed versions rather than disallowing us to make changes on HEAD.

git clone https://github.com/AI-Hypercomputer/xpk.git
git checkout v0.13.0

It seems important, affecting many users. Telemetry is behind a feature flag, so only testers should experience any breakage, and only if they run python3 xpk.py, not if they use regular installed xpk.

I think we can keep all other changes from original PR, only xpk.py needs to be reverted.

@SikaGrr SikaGrr merged commit 9246bb3 into main Nov 10, 2025
17 checks passed
@SikaGrr SikaGrr deleted the revert-812-kill-python3-xpk-py branch November 10, 2025 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants