Fix single-host TPU nodepools, always set num-nodes if not flex. #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Hi @SikaGrr, I've received your request, and I'm working on it now! You can track my progress in the logs for more details. |
scaliby
approved these changes
Nov 12, 2025
FIoannides
approved these changes
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes single-host nodepools creation (tpu topology should not be set in those cases). Also, always set num nodes unless flex.
Testing
Created a single-host single-slice cluster (before and after the fix), checked the created nodepools (tpu topology was present, isn't anymore), executed a workload on it succesfully.
Goldens show fixes in commands (tpu7x-8 used in most commands is single-host), added another golden for multi-host.