Fix credentials retrieval #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scaliby
requested review from
FIoannides,
SikaGrr and
jamOne-
as code owners
scaliby
force-pushed
the
credentials-retrieval-fix
branch
from
f9d815d to
f1b0d48
Compare
jamOne-
requested changes
Nov 12, 2025
Collaborator
jamOne-
left a comment
jamOne-
left a comment
There was a problem hiding this comment.
left some nits. Thanks for the fix
jamOne-
approved these changes
Nov 13, 2025
scaliby
force-pushed
the
credentials-retrieval-fix
branch
from
82cfce5 to
dfe6c2a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Existing error code check seems to be too narrow, as communication to the cluster can fail with broad amount of errors that can be fixed by removing the
--dns-endpointflag. I modified the logic so it always retries without--dns-endpointwhen listing pods fails.Issue
b/460038063
Testing
Tested manually and added unit tests.