Skip to content

Commit 39bdcbf

Browse files
committed
refactor: completion test refactor
1 parent 4d2684b commit 39bdcbf

File tree

2 files changed

+19
-21
lines changed

2 files changed

+19
-21
lines changed

ai21/clients/bedrock/resources/bedrock_completion.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
from __future__ import annotations
2+
13
from typing import List
24

35
from ai21.clients.bedrock.resources.bedrock_resource import BedrockResource

tests/integration_tests/clients/bedrock/test_completion.py

Lines changed: 17 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -40,28 +40,24 @@ def test_completion__when_no_penalties__should_return_response(
4040
frequency_penalty: Optional[Penalty], presence_penalty: Optional[Penalty], count_penalty: Optional[Penalty]
4141
):
4242
client = AI21BedrockClient()
43+
completion_args = dict(
44+
prompt=_PROMPT,
45+
max_tokens=64,
46+
model_id=BedrockModelID.J2_MID_V1,
47+
temperature=0,
48+
top_p=1,
49+
top_k_return=0,
50+
)
4351

44-
if frequency_penalty is None and presence_penalty is None and count_penalty is None:
45-
response = client.completion.create(
46-
prompt=_PROMPT,
47-
max_tokens=64,
48-
model_id=BedrockModelID.J2_MID_V1,
49-
temperature=0,
50-
top_p=1,
51-
top_k_return=0,
52-
)
53-
else:
54-
response = client.completion.create(
55-
prompt=_PROMPT,
56-
max_tokens=64,
57-
model_id=BedrockModelID.J2_MID_V1,
58-
temperature=0,
59-
top_p=1,
60-
top_k_return=0,
61-
frequency_penalty=frequency_penalty,
62-
presence_penalty=presence_penalty,
63-
count_penalty=count_penalty,
64-
)
52+
for arg_name, penalty in [
53+
("frequency_penalty", frequency_penalty),
54+
("presence_penalty", presence_penalty),
55+
("count_penalty", count_penalty),
56+
]:
57+
if penalty:
58+
completion_args[arg_name] = penalty
59+
60+
response = client.completion.create(**completion_args)
6561

6662
assert response.prompt.text == _PROMPT
6763
assert len(response.completions) == 1

0 commit comments

Comments
 (0)