Skip to content

fix: remove redundant dependency - dataclass json #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 31, 2024
Merged

fix: remove redundant dependency - dataclass json #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5141d7c
fix: remove redundant dependency - dataclass json
miri-bar Jul 30, 2024
855878a
chore: use j2 ultra in examples
miri-bar Jul 30, 2024
a49b98d
Merge branch 'main' into remove_dep
Josephasafg Jul 30, 2024
c4e2521
Merge branch 'main' into remove_dep
Josephasafg Jul 30, 2024
4fc4b15
Merge branch 'main' into remove_dep
Josephasafg Jul 30, 2024
9a59c7f
test: use j2 ultra in completion tests
miri-bar Jul 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/bedrock/async_completion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ async def main():
temperature=0,
top_p=1,
top_k_return=0,
model=BedrockModelID.J2_MID_V1,
model=BedrockModelID.J2_ULTRA_V1,
)

print(response.completions[0].data.text)
Expand Down
2 changes: 1 addition & 1 deletion examples/bedrock/completion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
)

response = AI21BedrockClient().completion.create(
prompt=prompt, max_tokens=50, temperature=0, top_p=1, top_k_return=0, model=BedrockModelID.J2_MID_V1
prompt=prompt, max_tokens=50, temperature=0, top_p=1, top_k_return=0, model=BedrockModelID.J2_ULTRA_V1
)

print(response.completions[0].data.text)
Expand Down
49 changes: 4 additions & 45 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@ packages = [
python = "^3.8"
ai21-tokenizer = ">=0.11.0,<1.0.0"
boto3 = { version = "^1.28.82", optional = true }
dataclasses-json = "^0.6.3"
typing-extensions = "^4.9.0"
httpx = "^0.27.0"
tenacity = "^8.3.0"
Expand Down
4 changes: 2 additions & 2 deletions tests/integration_tests/clients/bedrock/test_completion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def test_completion_penalties__should_return_response(
completion_args = dict(
prompt=_PROMPT,
max_tokens=64,
model_id=BedrockModelID.J2_MID_V1,
model_id=BedrockModelID.J2_ULTRA_V1,
temperature=0,
top_p=1,
top_k_return=0,
Expand Down Expand Up @@ -111,7 +111,7 @@ async def test_async_completion_penalties__should_return_response(
completion_args = dict(
prompt=_PROMPT,
max_tokens=64,
model_id=BedrockModelID.J2_MID_V1,
model_id=BedrockModelID.J2_ULTRA_V1,
temperature=0,
top_p=1,
top_k_return=0,
Expand Down