Skip to content

Conversation

@amirai21
Copy link
Contributor

@amirai21 amirai21 commented Nov 6, 2024

Removing all TSMs, custom-models, datasets and J2 support.

path = f"{path}/{self._module_name}"

def _get_completion_path(self, model: str):
path = f"/{model}/{self._module_name}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's turn it into an inline return :)

@@ -0,0 +1 @@
<your content goes here>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file needed?

@@ -0,0 +1 @@
<your content goes here>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file needed?

"AI21BedrockClient",
"AI21SageMakerClient",
"BedrockModelID",
"SageMaker",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove - AsyncAI21SageMakerClient

from ai21.models.responses.segmentation_response import SegmentationResponse
from ai21.models.responses.summarize_by_segment_response import SummarizeBySegmentResponse, SegmentSummary, Highlight
from ai21.models.responses.summarize_response import SummarizeResponse
from ai21.models.summary_method import SummaryMethod
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about this?

)


def get_studio_chat(is_async: bool = False):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Remove

@pytest.mark.parametrize(
ids=[
"async_studio_answer",
"async_studio_chat",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

from ai21.models.ai21_base_model import AI21BaseModel
from tests.unittests.clients.studio.resources.conftest import (
get_studio_answer,
get_studio_chat,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

return answer_response, expected_dict, AnswerResponse


def get_chat_response():
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@github-actions github-actions bot added the lgtm Looks Good to Me label Nov 11, 2024
@amirai21 amirai21 changed the title Sunset tsms and j2 feat: Sunset tsms and j2 Nov 11, 2024
@amirai21 amirai21 merged commit b39c92c into main Nov 11, 2024
46 checks passed
@amirai21 amirai21 deleted the sunset-tsms-and-j2 branch November 11, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

aws documentation Documentation Update lgtm Looks Good to Me size:xxl

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants