feat: Batch API in Beta #278
Conversation
| **kwargs, | ||
| } | ||
| ) | ||
|
|
There was a problem hiding this comment.
The below looks like a generic util func that can be used globally in the sdk
There was a problem hiding this comment.
Its currently used only for this list function. when we have a second list function that requires similar handling, i'll move it to the http client. but for now I think its okay to leave it here
| class Batch(AI21BaseModel): | ||
| id: str | ||
| """The ID of the batch.""" | ||
| status: Literal["FAILED", "PROCESSING", "COMPLETED", "EXPIRED", "CANCELLED", "PENDING"] |
|
|
||
| ResponseT = TypeVar("_ResponseT", bound=Union["AI21BaseModel", str, httpx.Response, List[Any]]) | ||
| StreamT = TypeVar("_StreamT", bound=Stream[Any]) | ||
| AsyncStreamT = TypeVar("_AsyncStreamT", bound=AsyncStream[Any]) |
There was a problem hiding this comment.
PaginationT rename suggestion to be extra clear -> SyncPaginationT
| params: Dict[str, Any] | None = None, | ||
| response_cls: Type[PageT] | None = None, | ||
| **kwargs: Any, | ||
| ): |
There was a problem hiding this comment.
can we change self.request_method to self.or fetch_items_method (or similar) to make it clear what it does? (the first sounds like its http verb)
There was a problem hiding this comment.
Oops rename was missed. I called it request_callback is that ok with you?
| self, | ||
| after: str | NotGiven = NOT_GIVEN, | ||
| limit: int | NotGiven = NOT_GIVEN, | ||
| ) -> AsyncPagination[Batch]: |
There was a problem hiding this comment.
worth a docstring that limit will control the page_size of this paginated api
Josephasafg
force-pushed
the
feat_batch_api
branch
from
355986b to
cc9d55a
Compare
3 participants
No description provided.