Skip to content

Conversation

MichalAI21
Copy link
Collaborator

This new feature exposing data sources that were used by Maestro.

@MichalAI21 MichalAI21 added the feature New functionality label Apr 27, 2025
@github-actions github-actions bot added size:l lgtm Looks Good to Me and removed size:m labels Apr 27, 2025
@Josephasafg Josephasafg changed the title Maestro - add data sources support feat: Maestro - add data sources support Apr 27, 2025
description: str


class FileSearchResult(TypedDict):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add total=False to the class signature, otherwise it would require the user to pass None instead of explicitly not passing anything

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless that is something you want the users to pass - {'text': None}

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the returned type, but ok!

@MichalAI21 MichalAI21 enabled auto-merge (squash) April 28, 2025 06:36
@MichalAI21 MichalAI21 disabled auto-merge April 28, 2025 06:36
@MichalAI21 MichalAI21 merged commit 0764852 into main Apr 28, 2025
27 checks passed
@MichalAI21 MichalAI21 deleted the EXEC-1189-add-data-sources-to-maestro branch April 28, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New functionality lgtm Looks Good to Me size:l

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants