Skip to content

fix: remove optional parameter from maestro requests #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025
Merged

fix: remove optional parameter from maestro requests #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7ab49a
fix: remove optional parameter from maestro requests
pazshalev May 12, 2025
a85ba2e
fix: remove jamba instruct tests
pazshalev May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ai21/clients/common/maestro/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from __future__ import annotations

from abc import ABC, abstractmethod
from typing import List, Dict, Any
from typing import List

from ai21.models.chat import ChatMessage
from ai21.models.maestro.run import (
Expand All @@ -28,7 +28,6 @@ def _create_body(
models: List[str] | NotGiven,
tools: List[Tool] | NotGiven,
tool_resources: ToolResources | NotGiven,
context: Dict[str, Any] | NotGiven,
requirements: List[Requirement] | NotGiven,
budget: Budget | NotGiven,
include: List[OutputOptions] | NotGiven,
Expand All @@ -40,7 +39,6 @@ def _create_body(
"models": models,
"tools": tools,
"tool_resources": tool_resources,
"context": context,
"requirements": requirements,
"budget": budget,
"include": include,
Expand All @@ -56,7 +54,6 @@ def create(
models: List[str] | NotGiven = NOT_GIVEN,
tools: List[Tool] | NotGiven = NOT_GIVEN,
tool_resources: ToolResources | NotGiven = NOT_GIVEN,
context: Dict[str, Any] | NotGiven = NOT_GIVEN,
requirements: List[Requirement] | NotGiven = NOT_GIVEN,
budget: Budget | NotGiven = NOT_GIVEN,
include: List[OutputOptions] | NotGiven = NOT_GIVEN,
Expand All @@ -80,7 +77,6 @@ def create_and_poll(
models: List[str] | NotGiven = NOT_GIVEN,
tools: List[Tool] | NotGiven = NOT_GIVEN,
tool_resources: ToolResources | NotGiven = NOT_GIVEN,
context: Dict[str, Any] | NotGiven = NOT_GIVEN,
requirements: List[Requirement] | NotGiven = NOT_GIVEN,
budget: Budget | NotGiven = NOT_GIVEN,
include: List[OutputOptions] | NotGiven = NOT_GIVEN,
Expand Down
10 changes: 1 addition & 9 deletions ai21/clients/studio/resources/maestro/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

import asyncio
import time
from typing import Any, List, Dict
from typing import List

from ai21.clients.common.maestro.run import BaseMaestroRun
from ai21.clients.studio.resources.studio_resource import StudioResource, AsyncStudioResource
Expand All @@ -29,7 +29,6 @@ def create(
models: List[str] | NotGiven = NOT_GIVEN,
tools: List[Tool] | NotGiven = NOT_GIVEN,
tool_resources: ToolResources | NotGiven = NOT_GIVEN,
context: Dict[str, Any] | NotGiven = NOT_GIVEN,
requirements: List[Requirement] | NotGiven = NOT_GIVEN,
budget: Budget | NotGiven = NOT_GIVEN,
include: List[OutputOptions] | NotGiven = NOT_GIVEN,
Expand All @@ -40,7 +39,6 @@ def create(
models=models,
tools=tools,
tool_resources=tool_resources,
context=context,
requirements=requirements,
budget=budget,
include=include,
Expand Down Expand Up @@ -76,7 +74,6 @@ def create_and_poll(
models: List[str] | NotGiven = NOT_GIVEN,
tools: List[Tool] | NotGiven = NOT_GIVEN,
tool_resources: ToolResources | NotGiven = NOT_GIVEN,
context: Dict[str, Any] | NotGiven = NOT_GIVEN,
requirements: List[Requirement] | NotGiven = NOT_GIVEN,
budget: Budget | NotGiven = NOT_GIVEN,
include: List[OutputOptions] | NotGiven = NOT_GIVEN,
Expand All @@ -89,7 +86,6 @@ def create_and_poll(
models=models,
tools=tools,
tool_resources=tool_resources,
context=context,
requirements=requirements,
budget=budget,
include=include,
Expand All @@ -107,7 +103,6 @@ async def create(
models: List[str] | NotGiven = NOT_GIVEN,
tools: List[Tool] | NotGiven = NOT_GIVEN,
tool_resources: ToolResources | NotGiven = NOT_GIVEN,
context: Dict[str, Any] | NotGiven = NOT_GIVEN,
requirements: List[Requirement] | NotGiven = NOT_GIVEN,
budget: Budget | NotGiven = NOT_GIVEN,
include: List[OutputOptions] | NotGiven = NOT_GIVEN,
Expand All @@ -118,7 +113,6 @@ async def create(
models=models,
tools=tools,
tool_resources=tool_resources,
context=context,
requirements=requirements,
budget=budget,
include=include,
Expand Down Expand Up @@ -154,7 +148,6 @@ async def create_and_poll(
models: List[str] | NotGiven = NOT_GIVEN,
tools: List[Tool] | NotGiven = NOT_GIVEN,
tool_resources: ToolResources | NotGiven = NOT_GIVEN,
context: Dict[str, Any] | NotGiven = NOT_GIVEN,
requirements: List[Requirement] | NotGiven = NOT_GIVEN,
budget: Budget | NotGiven = NOT_GIVEN,
include: List[OutputOptions] | NotGiven = NOT_GIVEN,
Expand All @@ -167,7 +160,6 @@ async def create_and_poll(
models=models,
tools=tools,
tool_resources=tool_resources,
context=context,
requirements=requirements,
budget=budget,
include=include,
Expand Down
24 changes: 0 additions & 24 deletions examples/studio/chat/chat_completions_jamba_instruct.py
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions tests/integration_tests/clients/test_studio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
argvalues=[
("tokenization.py",),
("chat/chat_completions.py",),
("chat/chat_completions_jamba_instruct.py",),
("chat/stream_chat_completions.py",),
("chat/chat_documents.py",),
("chat/chat_function_calling.py",),
Expand All @@ -31,7 +30,6 @@
ids=[
"when_tokenization__should_return_ok",
"when_chat_completions__should_return_ok",
"when_chat_completions_jamba_instruct__should_return_ok",
"when_stream_chat_completions__should_return_ok",
"when_chat_completions_with_documents__should_return_ok",
"when_chat_completions_with_function_calling__should_return_ok",
Expand Down
Loading