fix: add external tools #319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josephasafg
requested changes
Sep 9, 2025
ai21/models/maestro/run.py
Outdated
| type: Literal["object"] | ||
| properties: Dict[str, HTTPToolFunctionParamProperties] | ||
| required: List[str] | ||
| additionalProperties: Optional[bool] |
There was a problem hiding this comment.
Can you make it snake_case and then serialize it so it aligns with python's conventions?
benshuk
reviewed
Sep 9, 2025
ai21/models/maestro/run.py
Outdated
| Role = Literal["user", "assistant"] | ||
| RunStatus = Literal["completed", "failed", "in_progress", "requires_action"] | ||
| ToolType = Literal["file_search", "web_search"] | ||
| ToolType = Literal["file_search", "web_search", "http", "mcp"] |
There was a problem hiding this comment.
not sure we need to update it as each Tool schema has the type on its own
Josephasafg
reviewed
Sep 9, 2025
ai21/models/maestro/run.py
Outdated
|
|
||
|
|
||
| class McpTool(TypedDict, total=False): | ||
| type: Required[Literal["mcp"]] = "mcp" |
There was a problem hiding this comment.
If the type is required and there is only one option, is it really necessary to make it required?
Josephasafg
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the external tool use PRD
we shall expose external tools in the Maestro API. external tool can be HTTP or MCP. They are both added to the tools list in the maestro run.