Skip to content

Conversation

@DaMatrix
Copy link
Contributor

@DaMatrix DaMatrix commented Aug 2, 2024

Description

This fixes a stupid oversight in the OpenGL miner implementation: the default GLFW initialization callback causes a panic on failure, which caused the entire worker thread running the miner to exit prematurely.

Changelog

  • Make GLFW initialization error handling more robust by relaying any errors up to the caller
  • Added a .dockerignore file configured to ignore the irrelevant scratch files present in a development environment, because sending 7GiB of data to the docker build context seems somewhat excessive and makes stuff significantly slower

Type of Change

Please mark the appropriate option by putting an "x" inside the brackets:

  • Bug fix
  • New feature
  • Enhancement or optimization
  • Documentation update
  • Other (please specify)

Checklist

Put an "x" in the boxes that apply. If you're unsure about any of these, don't hesitate to ask. We're here to help!

  • I have tested the changes locally and they work as expected.
  • I have added necessary documentation or updated existing documentation.
  • My code follows the project's coding standards and style guidelines.
  • I have added/updated relevant tests to ensure the changes are properly covered.
  • I have checked for and resolved any merge conflicts.
  • My commits have clear and descriptive messages.

Screenshots (if applicable)

If the changes affect the UI or have visual effects, please provide screenshots or GIFs showcasing the changes.

Additional Context (if applicable)

Add any additional context or information about the changes that may be helpful in understanding the pull request.

Related Issues (if applicable)

If this pull request is related to any existing issues, please list them here.

Requested Reviewers

Mention any specific individuals or teams you would like to request a review from.

This massively speeds up docker build times in a development environment by not sending all temporary local build files (such as the local cargo cache) to the docker context every single time.
@DaMatrix DaMatrix requested a review from a team as a code owner August 2, 2024 11:37
@BarryBoot BarryBoot merged commit 3257de2 into AIBlockOfficial:difficulty_function_gpu Aug 2, 2024
@DaMatrix DaMatrix deleted the difficulty_function_gpu branch August 2, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants