added and incorporated basic presentation components #1
Conversation
src/app/app.module.ts
Outdated
| BrowserModule, | ||
| BrowserAnimationsModule, | ||
| FeCommonModule, | ||
| MatToolbarModule |
There was a problem hiding this comment.
Is MatToolBarModule required here? These can get out of controller quickly so we want to limit how much is included in the master scope.
There was a problem hiding this comment.
Nope I missed that one, I'll remove it
src/app/common/common.module.ts
Outdated
| exports: [ | ||
| LoginComponent, TextBoxComponent, CheckBoxComponent] | ||
| declarations: [TextBoxComponent, LoginComponent, CheckBoxComponent, ToolbarComponent, RaisedButtonComponent, BasicButtonComponent], | ||
| exports: [LoginComponent, TextBoxComponent, CheckBoxComponent, ToolbarComponent, RaisedButtonComponent, MatFormFieldModule], |
There was a problem hiding this comment.
Just like the above comment, are all these exports needed?
| }) | ||
| export class CheckBoxComponent implements OnInit { | ||
|
|
||
| label = 'Remember my credentials' |
There was a problem hiding this comment.
This label should be dynamic and passed as @input(). Before merging these all presentation components need to be completed or at least in a reusable state.
| @@ -0,0 +1,3 @@ | |||
| <mat-toolbar color="primary"> | |||
| <span>{{title}}</span> | |||
| </mat-toolbar> No newline at end of file | |||
There was a problem hiding this comment.
No newline at end of file. There are plug-ins for Visual Studio Code that will do this automatically for you.
src/index.html
Outdated
| <meta name="viewport" content="width=device-width, initial-scale=1"> | ||
| <link rel="icon" type="image/x-icon" href="favicon.ico"> | ||
| <link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet"> | ||
| <link rel="stylesheet" href="https://fonts.googleapis.com/css?family=Roboto:300,400,500,700,400italic"> |
There was a problem hiding this comment.
Are you using all these font types? Only include the ones you are using because they add to the load time of the page.
| <p> | ||
| DRIVER-CHECKBOX | ||
| </p> | ||
| <mat-checkbox [color]="color">{{label}}</mat-checkbox> |
There was a problem hiding this comment.
checkbox needs to store a model that can be retrieved and have an event emitter for changes.
| @@ -0,0 +1,3 @@ | |||
| <button mat-icon-button> | |||
There was a problem hiding this comment.
This will need a click event emitter
| @@ -0,0 +1,17 @@ | |||
| <mat-card> | |||
| <mat-card-title> | |||
| SidenavBasic | |||
There was a problem hiding this comment.
No, I wasn't sure if I should add the sidebar files in case we use them later, but I can get rid of them.
| <input type="text" [id]="id" [placeholder]="placeholder" [value]="value" (click)="click($event)" /> | ||
| <div class="form-template"> | ||
| <mat-form-field [color]="warn"> | ||
| <input matInput placeholder={{placeholder}} [type]="hide ? 'password' : 'text'"> |
There was a problem hiding this comment.
mutliple event emitters need to be exposed here, onkeyup and etc... Also, there needs to be a way to describe a model that can be passed from a parent.
No description provided.