Skip to content

Swap get_type to py::type::of #453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 14, 2025
Merged

Swap get_type to py::type::of #453

merged 2 commits into from
Jul 14, 2025

Conversation

@roelof-groenewald
Copy link
Contributor

@roelof-groenewald roelof-groenewald commented Jul 14, 2025 •
edited by ax3l
Loading

This fixes a new failure in WarpX CI (see https://github.com/BLAST-WarpX/warpx/actions/runs/16272157144/job/45942282535?pr=5872) due to deprecation of get_type().

/Users/runner/work/warpx/warpx/build_sp/_deps/fetchedpyamrex-src/src/Base/MPMD.cpp:108:35: error: 'get_type' is deprecated: Call py::type::handle_of(h) or py::type::of(h) instead of h.get_type() [-Werror,-Wdeprecated-declarations]
                      app_comm_py.get_type()))
                                  ^
/opt/homebrew/include/pybind11/detail/../pytypes.h:215:5: note: 'get_type' has been explicitly marked deprecated here
    PYBIND11_DEPRECATED("Call py::type::handle_of(h) or py::type::of(h) instead of h.get_type()")
    ^
/opt/homebrew/include/pybind11/detail/common.h:171:43: note: expanded from macro 'PYBIND11_DEPRECATED'
#    define PYBIND11_DEPRECATED(reason) [[deprecated(reason)]]
                                          ^
1 error generated.

@roelof-groenewald
swap get_type to py::type::of
6036dd3 
Signed-off-by: Roelof Groenewald <rgroenewald@tae.com>
ax3l
ax3l approved these changes Jul 14, 2025
View reviewed changes
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Gotta push the same to openPMD-api :) (where I got this snippet from/developed it first)

ax3l
ax3l reviewed Jul 14, 2025
View reviewed changes
@ax3l
Fix Missing )
1ce7fcc 
Signed-off-by: Axel Huebl <axel.huebl@plasma.ninja>
@ax3l ax3l enabled auto-merge (squash) July 14, 2025 17:00
@ax3l ax3l self-assigned this Jul 14, 2025
@ax3l ax3l added the warning label Jul 14, 2025
@ax3l ax3l merged commit 2a2587b into AMReX-Codes:development Jul 14, 2025
17 checks passed
@roelof-groenewald roelof-groenewald deleted the fix_get_type branch July 14, 2025 19:39
ax3l added a commit to BLAST-ImpactX/impactx that referenced this pull request Jul 16, 2025
@ax3l
CI: Temp no Werror In macOS
636ec29 
Wait for AMReX-Codes/pyamrex#453
ax3l added a commit to ax3l/impactx that referenced this pull request Jul 16, 2025
@ax3l
CI: macOS w/ -Werror Again
54ab496 
Add `-Werror` back to macOS CI.
Was temporarily disabled until
AMReX-Codes/pyamrex#453
landed in ImpactX.
@ax3l ax3l mentioned this pull request Jul 16, 2025
Merged
2 tasks
ax3l added a commit to ax3l/impactx that referenced this pull request Aug 10, 2025
@ax3l
CI: macOS w/ -Werror Again
6bb8b63 
Add `-Werror` back to macOS CI.
Was temporarily disabled until
AMReX-Codes/pyamrex#453
landed in ImpactX.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ax3l ax3l ax3l approved these changes

Assignees

@ax3l ax3l

Labels

warning

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@roelof-groenewald @ax3l