Skip to content

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Jan 14, 2022

Print compilation messages and script output messages when
they fail. This is needed for CI to spot the underlying error.

Port of ECP-WarpX@8abcbe3 by @RemiLehe

ping @EZoni

@ax3l ax3l force-pushed the topic-printFailedBuildTest branch from dd6691a to 9c8805d Compare January 14, 2022 17:41
@ax3l ax3l requested a review from zingale January 14, 2022 17:43
@zingale
Copy link
Member

zingale commented Jan 14, 2022

can we make this an option? I run on the commandline a lot and this will really clutter things up.

@ax3l
Copy link
Member Author

ax3l commented Jan 14, 2022

Yes, absolutely no problem :) Do you like to propose/push an option for it?

@zingale
Copy link
Member

zingale commented Jan 14, 2022

what about just adding a general verbose option to the suite?

@ax3l
Copy link
Member Author

ax3l commented Jan 14, 2022

Sounds good to me, that would be on for our CI / non-interactive mode then :)

@ax3l
Copy link
Member Author

ax3l commented Jan 14, 2022

With regards to #106: We could also add printing of stdout and stderr file below suite.run_test(test, base_cmd) for verbose runs.

@ax3l
Copy link
Member Author

ax3l commented Jan 14, 2022

Option added in #116 :)

@zingale
Copy link
Member

zingale commented Jan 15, 2022

I think we need to merge main into this so the CI test passes

ax3l and others added 2 commits January 14, 2022 16:17
Print compilation messages and script output messages when
they fail. This is needed for CI to spot the underlying error.

Port of ECP-WarpX@8abcbe3 by @RemiLehe

Co-authored-by: Remi Lehe <remi.lehe@normalesup.org>
@ax3l ax3l force-pushed the topic-printFailedBuildTest branch from 4a148c4 to b483c36 Compare January 15, 2022 00:18
@ax3l
Copy link
Member Author

ax3l commented Jan 15, 2022

Thx, yes rebased now :)

@ax3l ax3l force-pushed the topic-printFailedBuildTest branch from b483c36 to 97b87e3 Compare January 15, 2022 00:36
@ax3l
Copy link
Member Author

ax3l commented Jan 15, 2022

@zingale thx, updated :)

@ax3l ax3l merged commit 71f6939 into AMReX-Codes:main Jan 15, 2022
@ax3l ax3l deleted the topic-printFailedBuildTest branch January 15, 2022 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants