Skip to content

CMake: Extra Configs & Superbuilds #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2021
Merged

CMake: Extra Configs & Superbuilds #91

merged 3 commits into from
Nov 13, 2021

Conversation

@ax3l
Copy link
Member

@ax3l ax3l commented Nov 13, 2021 •
edited
Loading

@ax3l ax3l force-pushed the cmake-extraConfig branch 2 times, most recently from bf509c1 to f74658a Compare November 13, 2021 05:17
@ax3l ax3l mentioned this pull request Nov 13, 2021
Merged
10 tasks
ax3l added 3 commits November 13, 2021 12:57
@ax3l
CMake: Extra Config Options per Test
56aedce 
Allow to change the CMake `cmakeSetupOpts` configuration options per
test.
@ax3l
CMake: Support Superbuilds
c6f5aea 
No reason to pre-build AMReX or Source if we might change everything
down the line.
@ax3l
CMake: Build with CMake
65a90d9 
No change of dir needed and will allow to change the generator down
the line.
@ax3l ax3l force-pushed the cmake-extraConfig branch from f74658a to 65a90d9 Compare November 13, 2021 20:57
@ax3l ax3l changed the title [WIP] CMake: Extra Configs & Superbuilds CMake: Extra Configs & Superbuilds Nov 13, 2021
@ax3l
Copy link
Member Author

ax3l commented Nov 13, 2021

@zingale ready for review/merge, too :)

@zingale zingale merged commit bfacd9c into AMReX-Codes:main Nov 13, 2021
@ax3l ax3l deleted the cmake-extraConfig branch November 13, 2021 23:30
@ax3l
Copy link
Member Author

ax3l commented Dec 17, 2021

Note @WeiqunZhang et al.: please update CMake to 3.12+ so it supports --parallel/-j on your nightly runners.

Recommended: upgrade to CMake 3.18+ or 3.20+.

@ax3l
Copy link
Member Author

ax3l commented Dec 17, 2021

Update: Garunda uses CMake 3.16.3 atm.

We are looking at a regression with MFix, let's check what's in f'cmake --build {self.source_build_dir} -j {self.numMakeJobs} -- {opts} {target}' for it :)

@WeiqunZhang
Copy link
Member

The old command is make -j8 all, whereas the new command is cmake --build -j 8 -- all.

@ax3l
Copy link
Member Author

ax3l commented Jan 14, 2022

@WeiqunZhang did we solve this?

@WeiqunZhang
Copy link
Member

No. We probably just need to replace {self.source_build_dir} with ..

@ax3l
Copy link
Member Author

ax3l commented Jan 14, 2022 •
edited
Loading

Yep, or it should read test.buildDir, but we don't pass the test object in here yet.
What is is setting in the per-test buildDir?

[testName]
buildDir = .

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zingale zingale zingale approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ax3l @WeiqunZhang @zingale