Support PostgreSQL v12 #450

gclough · 2019-10-03T15:47:06Z

No description provided.

defaults/main.yml

gclough · 2019-10-04T13:20:39Z

@thbar ... OK, I think it's working now. I had to do a smaller PR than I wanted to, but I'll follow up with an Ubuntu 18.04 one soon.

.travis.yml

README.md

Vagrantfile

gclough · 2019-10-07T08:53:07Z

vagrant-inventory

-## DISABLED ## fedora27.local ansible_ssh_host=192.168.88.27 ansible_ssh_port=22 ansible_ssh_user=vagrant ansible_ssh_private_key_file=~/.vagrant.d/insecure_private_key
-trusty64.local ansible_ssh_host=192.168.88.28 ansible_ssh_port=22 ansible_ssh_user=vagrant ansible_ssh_private_key_file=~/.vagrant.d/insecure_private_key
-precise64.local ansible_ssh_host=192.168.88.29 ansible_ssh_port=22 ansible_ssh_user=vagrant ansible_ssh_private_key_file=~/.vagrant.d/insecure_private_key
+ubuntu16.local ansible_ssh_host=192.168.88.10 ansible_ssh_port=22 ansible_ssh_user=vagrant ansible_ssh_private_key_file=~/.vagrant.d/insecure_private_key


Reorg with new IP address ranges, one for each OS type

defaults/main.yml

gclough · 2019-10-08T09:17:57Z

@thbar , I had to setup a new system to use different defaults for different versions, as some variables change between versions.

tasks/main.yml

vars/postgresql_12.yml

gclough · 2019-10-08T09:49:56Z

@thbar , @otakup0pe , @UnderGreen , @jlozadad . Could someone review this please?

thbar · 2019-10-08T10:04:44Z

@gclough I had a first quick look and things look reasonable.

I will try to the role on a < 12 setup to verify that nothing changes (although I don't expect any trouble), and will also try out the modified Vagrant setup to get my feet wet there.

vars/postgresql_10.yml

thbar · 2019-10-15T13:01:36Z

@gclough I did a round of testing today, here is a first bit of feedback:

Existing systems configured with version 9.5 and 10 are unaffected, no changes reported (which is good)
An install for version 12 failed due to PostGIS:

TASK [ANXS.postgresql : PostgreSQL | Extensions | Make sure the postgis extensions are installed | Debian] *********************************************************************************************************
fatal: [vagrant-geo]: FAILED! => changed=false 
  msg: No package matching 'postgresql-12-postgis-2.3' is available

I'll keep you posted if I have more information about that failure.

thbar · 2019-10-15T13:49:32Z

On PostGIS failure, it seems related to lack of available package for Postgres 12 (despite what is written on https://trac.osgeo.org/postgis/wiki/UsersWikiPostgreSQLPostGIS).

Using postgresql_version: 12 and postgresql_ext_postgis_version: 2.5 still fails.

sudo apt-cache search postgis | grep postgresql-12-postgis will return empty result, while older versions (e.g. sudo apt-cache search postgis | grep postgresql-11-postgis) will return the currently in use convention (postgresql-11-postgis-2.5).

I don't know if it's a temporary trouble, or something that will need some care. Merging of this PR could be done, but we should probably open an issue for PostGIS on Postgres 12 once it's done to track this.

thbar

Except for the PostGIS package issue (which I think is probably temporary, and could be handled separately afterwards), this PR looks good to me.

I was able to:

Keep systems with v9.5 and v10 unchanged
Install v12 (after manually removing with sudo apt-get remove postgresql-common postgresql-client-common) on a VM, and get a successfully working app (without PostGIS)

thbar · 2019-10-15T14:02:28Z

Likely explanation on the PostGIS issue I met: I believe 2.5 was recently (circa 4th of October) added to compatibility matrix, but packagers may not have built it yet (https://twitter.com/pwramsey/status/1180160479584378880).

gclough · 2019-10-25T09:20:59Z

Thanks @thbar ... so long as this doesn't affect backwards compatibility with older versions, then I'll commit the change and we can fix-forward.

I'm just resolving a conflict now, and then we should be good to go.

Cheers,
Greg.

Support PostgreSQL v12

thbar reviewed Oct 3, 2019

View reviewed changes

defaults/main.yml Outdated Show resolved Hide resolved

gclough force-pushed the postgresql_12 branch 2 times, most recently from 8f2fe51 to 7ee283f Compare October 4, 2019 11:42