Skip to content

feat: compgen -W option completion #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2025
Merged

feat: compgen -W option completion #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions scripts/bash_pinyin_completion
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,26 @@ _comp_compgen__call_builtin() {
esac
done

# Also check if -W option is used with ${files[@]} or similar array expansion
# which is a common pattern for file completion
if [[ "$is_file_completion" == false ]]; then
local i=0
while [[ $i -lt ${#compgen_args[@]} ]]; do
if [[ "${compgen_args[$i]}" == "-W" ]]; then
local next_idx=$((i + 1))
if [[ $next_idx -lt ${#compgen_args[@]} ]]; then
local word_arg="${compgen_args[$next_idx]}"
# Check if it contains ${files or similar array patterns
if [[ "$word_arg" == *'${files'* ]] || [[ "$word_arg" == *'${toks'* ]] || [[ "$word_arg" == *'$files'* ]] || [[ "$word_arg" == *'$toks'* ]]; then
is_file_completion=true
break
fi
fi
fi
((i++))
done
fi

# If this looks like file completion, add pinyin matches
if [[ "$is_file_completion" == true ]]; then
_add_completion "$@"
Expand Down