-
Notifications
You must be signed in to change notification settings - Fork 647
Hook to android keyboard events #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hook to android keyboard events #29
Conversation
lib/KeyboardAwareScrollView.js
Outdated
| <ScrollView | ||
| ref='_rnkasv_keyboardView' | ||
| keyboardDismissMode='interactive' | ||
| keyboardShouldPersistTaps={true} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change isn't needed because you can pass keyboardShouldPersistTaps through KeyboardAwareScrollView props.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I just put it as default! But I can remove
|
Hello @grsabreu! Thanks for this PR. I've added some feedback to your code. I will try to test and integrate this as soon as possible. |
|
Thanks for the feedback! Sorry about the delay on replying |
|
Can you rebase against master & squash your commits? |
|
Ok! I'll do that ASAP |
395e813 to
7ac2217
Compare
|
@alvaromb just finished what you proposed and pushed, tell me if anything else is needed |
|
@alvaromb any updates on this? |
| const _KAM_KEYBOARD_OPENING_TIME = 250 | ||
| const _KAM_EXTRA_HEIGHT = 75 | ||
|
|
||
| const isAndroid = () => Platform.OS === 'android' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change this to:
const isAndroid = Platform.OS === 'android'It's not necessary to run the function every time you need to check if it's Android or not.
|
The props contentInset work only on IOS |
|
You can use this: <ScrollView //...props>
{this.props.children}
<View style={{ height: this.state.keyboardSpace }} />
</ScrollView>https://github.com/sarovin/react-native-scrollview-smart/blob/master/lib/ScrollViewSmart.js |
|
ok! I'll check the comments and update the PR ASAP |
|
Closed in favor of #71 |
I had some issues on Android and I could solve them with these fixes.
The issues were:
Tell if I need to do something before merging. And thanks for the awesome package!