🐛 Fix hanging processes and subprocess termination #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| func setGroupAttrToCmd(c *exec.Cmd) { | ||
| c.SysProcAttr = &syscall.SysProcAttr{ | ||
| HideWindow: true, | ||
| CreationFlags: syscall.CREATE_UNICODE_ENVIRONMENT | syscall.CREATE_NEW_PROCESS_GROUP, |
Contributor
There was a problem hiding this comment.
Could you comment a link to docs for these?
Contributor
Author
There was a problem hiding this comment.
I added a link to Windows reference doc on this
| isRunning atomic.Bool | ||
| command *command | ||
| processMonitoring *subprocessMonitoring | ||
| messsaging *subprocessMessaging |
Contributor
There was a problem hiding this comment.
This was a great mistake
joshjennings98
previously approved these changes
Apr 3, 2024
acabarbaye
commented
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Test Coverage