Skip to content

🐛 subprocess Make sure that cancellation can't enter deadlock #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

🐛 subprocess Make sure that cancellation can't enter deadlock #681

merged 1 commit into from
Aug 18, 2025

Conversation

@joshjennings98
Copy link
Contributor

@joshjennings98 joshjennings98 commented Aug 18, 2025

Description

Make sure that cancellation can't enter deadlock

Test Coverage

  • This change is covered by existing or additional automated tests.
  • Manual testing has been performed (and evidence provided) as automated testing was not feasible.
  • Additional tests are not required for this change (e.g. documentation update).

acabarbaye
acabarbaye approved these changes Aug 18, 2025
View reviewed changes
Copy link
Contributor

@acabarbaye acabarbaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot

@acabarbaye acabarbaye merged commit 6cb5a22 into master Aug 18, 2025
6 checks passed
@acabarbaye acabarbaye deleted the cancel-deadlock branch August 18, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acabarbaye acabarbaye acabarbaye approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@joshjennings98 @acabarbaye