Missing state changes in "Manage Solution" dialog (unreleased version)

[jreineckearm]

Type: Bug Report

Describe the bug

• OS and Version: Windows 11 Enterprise 24H2
• VS Code Version: 1.104.2
• Extension Version: Internal build from main
• Target Device: Alif AE722F80F55D5LS
• Other extensions you installed (and if the issue persists after disabling them):
• A clear and concise description of what the bug is.

Some findings from testing the Manage Solutions dialog after extension with debug configurations.
All based on using this example: https://github.com/Arm-Examples/cmsis-mlek-examples/tree/main/Alif/AppKit_D3/MLEK_AV_DualCore

Note: The example still is configured for CMSIS-Toolbox 2.10.0, make sure to use 2.11.0.

• The "Save" button doesn't always become active when I change the debugger selection. I haven't seen a clear pattern yet (first thought it was related to aliases for CMSIS-DAP debuggers, but turns out it wasn't).
• I sometimes can't change values in edit fields. This first seemed to be related to default clock values including "kHz". But I saw this also on entries without that unit extension. Saw this most of the times with the debug interface "clock" field.

  that issue is logged and handled in https://github.com/Arm-Debug/vscode-cmsis-csolution/pull/2498

• Clarification: what is the expected behavior for the following: open Manage Solutions dialog, change something in the debug section, do NOT save, close the dialog, reopen it? I think there would be two viable approaches, but I think the behaviour is somewhere in between
  • Restore all previous values when reopening the dialog. It doesn't do that at the moment.
  • Keep the previous changes and restore the entire state. It does keep the values, but I believe I saw the "Save" button state change. Also, in this case we need something like a "cancel", "restore", or "discard" button to get back to the original state that was modified.

To Reproduce

• Clone https://github.com/Arm-Examples/cmsis-mlek-examples.git
• Open subfolder Alif/AppKit_D3/MLEK_AV_DualCore in VS Code.
• Update vcpkg-configuration.json to use CMSIS-Toolbox 2.11.0
• Build the solution

Expected behavior

See descriptions above

Code sample and logs

• Code sample
• tasks.json

Screenshots

Additional context

[arneschmid]

The "Save" button doesn't always become active when I change the debugger selection. I haven't seen a clear pattern yet (first thought it was related to aliases for CMSIS-DAP debuggers, but turns out it wasn't).

cannot replicate this issue in the latest main build

[arneschmid]

Clarification: what is the expected behavior for the following: open Manage Solutions dialog, change something in the debug section, do NOT save, close the dialog, reopen it?

We are working on an enhance persistence logic where the user can select the desired action on closing the view. save / discard / re-open and keep the changes in memory

[jreineckearm]

cannot replicate this issue in the latest main build

Let me re-test. A lot happened since this was raised.

[ReinhardKeil]

The expected behavior is that all changes are lost and the user sees the current settings of the solution when the dialog opens again.

[jreineckearm]

"Save" button behavior has massively improved. I'd call the first item in the list resolved. Thanks!