New CMSIS-Toolbox version check seems early when creating new solution

[jreineckearm]

Type: Bug Report

Describe the bug

• OS and Version: Windows 11 Enterprise 24H2
• VS Code Version: 1.105.0
• Extension Version: Internal build 1.60.1-82-gc02d8b1
• Target Device: Board - LPCXpresso55S69
• Other extensions you installed (and if the issue persists after disabling them):
• A clear and concise description of what the bug is.

When I create a new solution with an example for the above board, I get the following warning(s):

Note that version "unknown" was detected and that the vcpkg-configuration.json contains expected minimum version. Got a suspicion that a new vcpkg-configuration.json was generated by the new solution flow, but only after the version check happened.

To Reproduce
Steps to reproduce the behavior:

1. Create new solution, I used freertos_hello_cm33_core0 for LPCXpresso55S69
2. Let things happen

Expected behavior

Check may need to be delayed until vcpkg-configuration.json got created by new solution flow. Or rerun when it got created. Though the latter might cause the warning still to show as notification.

Code sample and logs

• Code sample
• tasks.json

Screenshots

Additional context

[JonatanAntoni]

This could be a short-coming of not knowing exactly which toolbox is used. In your case it looks like another toolbox may be in use but the warning is always pinned to the vcpkg-configuration.json file regardless of the listed version. We can try to make this more elaborated.

[jreineckearm]

Thanks for the swift response. Interestingly, I cannot reproduce anymore after I cleaned up an inconsistent state of my pack installation folders. When I create that inconsistent state again, then I see it happening again.

So, my reproducer steps need to be amended by:

• Copy random files into the pack installation folder Arm/Packs/NXP/LPC55S69_DFP which is the base installation folder for the DFP used in my scenario.

UPDATE: Note, that you ideally start from a new VS Code window which hasn't loaded any csolution or vcpkg configuration yet.

[JonatanAntoni]

Having version unknown is clearly another issue not being able to run cbuild setup correctly. In this case we could decide to not show that warning because there are other issues from preventing the solution to work.

[jkrech]

This was my thinking as well. How are we retrieving the version that is "installed". This version maybe in the path already or is added via vcpkg-shell or is simply missing. If we cannot run cbuild we need to wait.

[JonatanAntoni]

The version is taken from the cbuild-idx.yml after cbuild setup completed.
In case of cbuild setup failed to properly write cbuild-idx.yml the check falls back to (unknown) and issues a warning.

[JonatanAntoni]

Shall we drop the warning if current version could not be detected?
By adding more logic we could even check if the version in vcpkg-configuration.json actually matches the detected version for linking the problem to the config file.