Skip to content

Feature: dynamic timeouts #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2018
Merged

Feature: dynamic timeouts #228

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
056b2fd
Add support for dynamic timeout set/adjust from DUT via {{__timeout_s…
screamerbg Nov 20, 2018
5090b13
Adjust the "adj" to "adjust" in "__timeout_adjust"
Dec 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions mbed_host_tests/host_tests_runner/host_test_default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,6 +433,14 @@ def process_code_coverage(key, value, timestamp):
self.logger.prn_inf("%s received"% (key))
callbacks__exit_event_queue = True
break
elif key == '__timeout_set':
Copy link
Contributor

@bridadan bridadan Nov 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The beginning of the test (the "preamble" as its referred to at the top of this file) sets the timeout of the test with the __timeout key. I'd say go ahead and reuse that key instead of making a new one, unless you have any objections.

Copy link
Contributor Author

@screamerbg screamerbg Dec 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __timeout key at "preamble" stage also sets the global timer to 0 and timeout duration. The behavior of __timer_set only sets the timeout duration, but doesn't change the global timer (e.g. time elapsed). I'd prefer not to confuse these two different behaviors.

Copy link
Contributor

@bridadan bridadan Dec 3, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a very good point, thanks very much for clarifying 😄

# Dynamic timeout set
timeout_duration = int(value) # New timeout
self.logger.prn_inf("setting timeout to: %d sec"% int(value))
elif key == '__timeout_adjust':
# Dynamic timeout adjust
timeout_duration = timeout_duration + int(value) # adjust time
Copy link
Contributor

@cmonr cmonr Dec 5, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to ask "what's the difference between adjust and set, but this was simple enough :)

self.logger.prn_inf("adjusting timeout with %d sec (now %d)" % (int(value), timeout_duration))
elif key in callbacks:
# Handle callback
callbacks[key](key, value, timestamp)
Expand Down