Warnings displayed when using .mbed repo scheme

[thegecko]

A valid way to create an mbed project is to have an .mbed file on the root instead of having the folder under source control.

When hydrating a project of this type (mbed deploy) the following warnings appears which shouldn't be there:

[mbed] WARNING: Program "my-application-1" in "/home/ubuntu/workspace/my-application-1" does not use source control management.
[mbed] WARNING: To fix this you should use "mbed new ." in the root of your program.

[screamerbg]

SCM is very convenient for both:

• local development - codebase versioning, not just the program, but also mbed-os and dependencies, e.g. switch back and forth between stable revisions of my program etc.
• remote development - publish, get updates etc.

Through this warning we'd like to encourage that SCM is used instead of plain folders.

[Mirrored to Jira]

[thegecko]

I disagree. Source control is not a requirement to use mbed-cli and it is valid to be used without it. Generating a warning is confusing, especially when outlining a 'fix' for it. As you cannot dismiss the warning, I recommend if this is shown that it is informational only.

[Mirrored to Jira]

[screamerbg]

Not having the program under SCM prevents the following workflows:

• mbed update in the program root will not update from remote repo
• mbed update [rev|branch|tag] in the program root will not switch to specific rev, branch, tag
• mbed publish will not publish the program, only changes is OS and libraries

As you say, source control is not a requirement, thus mbed CLI doesn't throw an error. It throws a warning though as this has a significant impact to the supported workflows.

[Mirrored to Jira]

[thegecko]

This issue is not resolved, please stop closing it.
I was explicitly asked about the appearance of this warning in a valid use case on cloud9. We should either display this as an "info" message or not at all. A warning or error should appear only when the user tries a workflow which requires SCM as you outline.
As it is subjective, I'd be interested from input from product, perhaps @jaustin?

This isn't a blocker for the release.

[Mirrored to Jira]

[janjongboom]

@screamerbg @thegecko This issue pops up again, now in JerryScript. Because it now actually errors instead of throw a warning it broke our JS on mbed builds with introduction of mbed CLI 1.0.0. See jerryscript-project/jerryscript#1511 and jerryscript-project/jerryscript#1512.

This behavior is not good, it forces the mbed project folder to be under either HG or GIT SCM, which does not make any sense. It breaks when the parent folder is under SCM but the mbed project folder isn't (e.g. one repo with multiple projects), or when you use another SCM system.
[Mirrored to Jira]

[theotherjimmy]

@thegecko To summarize:

Expected behavior

[mbed] INFO: Program "my-application-1" in "/home/ubuntu/workspace/my-application-1" does not use source control management.

or

Actual Behavior

[mbed] WARNING: Program "my-application-1" in "/home/ubuntu/workspace/my-application-1" does not use source control management.
[mbed] WARNING: To fix this you should use "mbed new ." in the root of your program.

[Mirrored to Jira]

[theotherjimmy]

Looking through the source, you should only see this warning when it's relevant: when you're asking for things like mbed update (could update the project working copy from scm), mbed add mbed remove (this one is debatable), mbed deploy mbed sync (could update the project's working copy from scm) mbed new, mbed ls (used to read current version), mbed status (it's so similar to git/hg status).

@thegecko @janjongboom Is there a command that's in the above list that should not be? is there a command that prints this warning that is not in that list?
[Mirrored to Jira]

[thegecko]

mbed deploy shouldn't require SCM IMO
[Mirrored to Jira]

[theotherjimmy]

I think it just warns about it, not requires it. I'm in agreement though: it's mainly for dep related stuff, so it should not complain about a lack of SCM for the base project.
[Mirrored to Jira]