psa: Avoid use of relative include paths #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relative include paths should be avoided. The build system will determine where to pull in includes from. Specifically, `#include "../mbedtls/config.h"` shouldn't be used. Use `#include "mbedtls/config.h` instead, so that the submodule-building makefiles can change which directory to use to get mbedtls include files from. Fixes ARMmbed#141
Patater
added
bug
gilles-peskine-arm
approved these changes
Jun 7, 2019
dgreen-arm
approved these changes
Jun 7, 2019
Patater
removed
the
needs: review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relative include paths should be avoided. The build system will
determine where to pull in includes from. Specifically,
#include "../mbedtls/config.h"shouldn't be used. Use#include "mbedtls/config.hinstead, so that the submodule-building makefiles canchange which directory to use to get mbedtls include files from.
Fixes #141