No logging configuration if create used

[jonikula]

If the create-method in mbed_lstools main is used to create the toolset, the logging module never receives any configuration so nothing ever gets logged. Is it assumed that the application calling create would configure the logging itself or should the start_logging method be automatically called in create?

[theotherjimmy]

@jonikula Really good question. I think that we should call start_logging in create, only if no logger currently is running. You could override the settings in your application that way, which is probably what we want.

[theotherjimmy]

@jonikula If there is no crash caused by forgetting to setup logging, then I see no harm to doing nothing, like we do now.

[jonikula]

Ok. We'll setup some configurations in the application then. Thanks.

[jupe]

There should be at least documentation for this - actually I propose to add NullHandler for logger always by default. It should not be application responsibility to configure logger for mbed-ls.

Anyway, this is not critical - but causes annoying consequences because application top of this capture these lines and it looks for end users like this is the root cause for e.g. flash failure even its not.. We could update application side for now but I highly propose to do something for this because it's very easy - and somebody else could run into the same situation.

[jupe]

In fact there should be also API to give custom logger instead of defaults ones.

[theotherjimmy]

@jupe That's the python logging module. I don't think that adding a duplicate API for mbed-ls is a good idea.

[jupe]

I mean custom logger instance instead of one that mbedls create, which might not be suitable for each use cases.

[theotherjimmy]

@jupe The Logger object itself does not have any policy decisions, and is a facade that forwards logging messages to the underlying Filter and Handler objects. It's possible, and encouraged, to assign the Filter and Handler objects through the logging module outside of mbed-ls. As such, I don't think that there is a need to be able to replace the Logger objects (there's like 6 of them) that mbed-ls uses.

[jupe]

Please document mbed-ls used logger at least so that its clear which one user can use and modify when it is needed. Browsing source code and guess logger name is not an option. Also that default ”NullHandler” would be good to have.

[theotherjimmy]

@jupe Can document! I'll make sure that the logger name is clear in the documentation. I'll add the "NullHandler" default in the same PR.

[theotherjimmy]

Alright, I made the default-to-null-logger PR.