Fix language matching in Windows #260
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@toyowata This should fix your problem, I'd appreciate it if you have a chance to test my branch! I wrote a test for it but nothing is as good as native Windows for this kind of stuff 😄 @theotherjimmy Could you please review? |
theotherjimmy
approved these changes
Nov 2, 2017
Contributor
theotherjimmy
left a comment
theotherjimmy
left a comment
There was a problem hiding this comment.
Thanks for taking the time to extend our test coverage.
Contributor
|
Wow, a red-green refactor cycle. Nice! |
Contributor
|
I locally applied your patch and the result is below: The reason is that the If I remove the utf-8 decoder call, it works in Japanese Windows. drive_list = re.match('\s*.*: ([A-Z:\\\\ ]*)', stdout).group(1) |
bridadan
force-pushed
the
fix_lang_matching_win
branch
from
e4d0bca to
558c4a3
Compare
Contributor
Author
|
Thanks for the feedback @toyowata. I couldn't just remove the Any chance you could try it again @toyowata. |
Contributor
|
@bridadan It looks fine. It's a bit odd, but that's what happens when you have an OS that has conflicting default encodings! |
bridadan
force-pushed
the
fix_lang_matching_win
branch
from
558c4a3 to
b6d9cac
Compare
Contributor
|
Thanks for your explanation. |
Contributor
|
Looks like we're good to go then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #259.
Previously the Windows implementation relied on the language of the system to work correctly (specifically, English). This dependency has been removed. It should work on all languages now.