Add porting guide for HAL I2C API #1103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnotherButler
requested review from
AnotherButler,
MarceloSalazar,
ashok-rao,
donatieng and
jamesbeyond
AnotherButler
approved these changes
Jul 9, 2019
Edit file, mostly for consistent tense and international spelling.
Fix outdated links that don't work anymore.
maciejbocianski
force-pushed
the
i2c_hal_porting_guide_update
branch
from
600c816 to
af1dc2d
Compare
|
|
AnotherButler
approved these changes
Jul 17, 2019
jamesbeyond
suggested changes
Jul 24, 2019
There was a problem hiding this comment.
shall we added the warnings about: this new API is on a feature branch, not master.
just like: https://github.com/ARMmbed/mbed-os-5-docs/blob/development/docs/porting/target/spi.md#serial-peripheral-interface-spi
Otherwise it all looks good
Add warning about code being on a feature branch to match docs in the rest of the section.
|
@jamesbeyond Is this OK now? |
jamesbeyond
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is updated version of #807
changes compared to #807:
I don't know how to fix following links:
http://os-doc-builder.test.mbed.com/docs/development/feature-i2c-doxy/classmbed_1_1_i_2_c.html
http://os-doc-builder.test.mbed.com/docs/development/feature-hal-i2c-doxy/group__hal__i2c__tests.html
@donatieng @jamesbeyond @MarceloSalazar @ashok-rao @AnotherButler
please review