PR template additions #102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teetak01
approved these changes
Jan 28, 2020
.github/pull_request_template.md
Outdated
| --> | ||
|
|
||
| [] I confirm this contribution is my own and I agree to license it with Apache 2.0. | ||
| [] I confirm the moderators may change the PR before merging it in. |
There was a problem hiding this comment.
Can we add an extra line to help to visualize this?
MarceloSalazar
approved these changes
Jan 28, 2020
MarceloSalazar
left a comment
MarceloSalazar
left a comment
There was a problem hiding this comment.
It looks good. Commented on minor things to tweak.
peknis01
suggested changes
Jan 29, 2020
Author
|
All issues fixed (reported so far), rebased, squashed and force-pushed. |
peknis01
suggested changes
Jan 29, 2020
Board PRs require a few more checks.
+ Changes from review comments (see original PR).
- Add link to TESTS-folder
- Mbed Enabled in capitals + link
- Add line changes.
- GitHub shows the content otherwise very strangely.
- Re-order, line also after board enablements.
- PR review changes per feedback from Pekka Niskanen
- Add notes on issues to Mbed OS & Client
- Maintainers update the hashes, but in order to get the issues
fixed in the 1st place -> issues need to get reported.
Author
|
Fixed one more time. :-) |
peknis01
approved these changes
Jan 29, 2020
JanneKiiskila
added
documentation
teetak01
approved these changes
Jan 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Board PRs require a few more checks.
[x] I confirm this contribution is my own and I agree to license it with Apache 2.0.
[x] I confirm the moderators may change the PR before merging it in.