Skip to content

Add Seeed Wio 3G support #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2020
Merged

Add Seeed Wio 3G support #86

merged 2 commits into from
Jan 28, 2020

Conversation

@toyowata
Copy link
Contributor

@toyowata toyowata commented Jan 9, 2020

The target uses STM32F439VI device.

Internal Flash : 2MB
RAM : 256kB
Connectivity : Cellular

kvstore : internal flash
Update storage : internal flash (1MB)

@iot-pdmc
Copy link
Collaborator

iot-pdmc commented Jan 9, 2020

Thanks for your changes.
@ARMmbed/pdmc-integrators please review.

teetak01
teetak01 suggested changes Jan 9, 2020
View reviewed changes
Copy link
Contributor

@teetak01 teetak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the README + provide test-results with provided test-framework:

https://github.com/ARMmbed/mbed-os-example-pelion#validation-and-testing-for-the-client-configuration

mbed_app.json Outdated
"update-client.storage-page" : 1,
"mbed-cloud-client.update-storage" : "ARM_UCP_FLASHIAP",
"storage_tdb_internal.internal_base_address": "(MBED_ROM_START+1024*1024)",
"storage_tdb_internal.internal_size" : "(128*1024)",
Copy link
Contributor

@teetak01 teetak01 Jan 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32 KiB would be enough.

Copy link
Contributor

@teetak01 teetak01 Jan 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also makes nice symmetry with the bootloader-size.

Copy link
Contributor Author

@toyowata toyowata Jan 10, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. storage_tdb_internal.internal_size should be 32kB (16*2) for the target. I also updated the bootloader binary.

@teetak01
Copy link
Contributor

teetak01 commented Jan 9, 2020

build-only

@toyowata
Copy link
Contributor Author

toyowata commented Jan 10, 2020 •
edited by teetak01
Loading

Test result


2020-01-10 12:00:47,038:tests.conftest:MainThread:INFO: -----  TEST RESULTS SUMMARY  -----
2020-01-10 12:00:47,039:tests.conftest:MainThread:INFO: [ check the complete fail reasons and code locations from this log or html report ]
2020-01-10 12:00:47,039:tests.conftest:MainThread:INFO: [passed] - dev-client-tests.py::test_01_get_device_id - (0.808s)
2020-01-10 12:00:47,039:tests.conftest:MainThread:INFO: [passed] - dev-client-tests.py::test_02_put_resource - (4.833s)
2020-01-10 12:00:47,039:tests.conftest:MainThread:INFO: [passed] - dev-client-tests.py::test_03_get_resource - (1.842s)
2020-01-10 12:00:47,039:tests.conftest:MainThread:INFO: [passed] - dev-client-tests.py::test_04_subscribe_resource - (2.840s)

@yogpan01 yogpan01 requested a review from teetak01 January 11, 2020 19:06
@yogpan01
Copy link
Contributor

yogpan01 commented Jan 11, 2020

@teetak01 Is this PR ready to be merged?
@MarceloSalazar FYI

@teetak01
Copy link
Contributor

teetak01 commented Jan 13, 2020

build-only

@MarceloSalazar
Copy link

MarceloSalazar commented Jan 13, 2020

Note WIO_3G platform is in Raas (helga).

@teetak01
Copy link
Contributor

teetak01 commented Jan 17, 2020

build-only

1 similar comment
@teetak01
Copy link
Contributor

teetak01 commented Jan 17, 2020

build-only

@MarceloSalazar
Copy link

MarceloSalazar commented Jan 22, 2020

@teetak01 can the build-only-test be re-started?

@teetak01
Copy link
Contributor

teetak01 commented Jan 23, 2020

build-only

teetak01
teetak01 approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@teetak01 teetak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash the commit together and rebase. Can be merged after that.

@toyowata
Copy link
Contributor Author

toyowata commented Jan 28, 2020

@teetak01
rebased the PR.

@teetak01
Copy link
Contributor

teetak01 commented Jan 28, 2020

build-only

@iot-pdmc
Copy link
Collaborator

iot-pdmc commented Jan 28, 2020

Test run: SUCCESS

Build artifacts

posted-by-tag: https://jenkins-client.isgtesting.com/job/mbed-os-example-pelion/

@teetak01 teetak01 merged commit 1af152b into ARMmbed:master Jan 28, 2020
@toyowata toyowata deleted the dev_wio_3g branch January 28, 2020 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@teetak01 teetak01 teetak01 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Requires CI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@toyowata @iot-pdmc @teetak01 @yogpan01 @MarceloSalazar