Update watchdog timing requirements #10839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fkjagodzinski, thank you for your changes. |
This was referenced Jun 17, 2019
added 6 commits
June 18, 2019 16:55
Update the watchdog timing requirements: 1. The watchdog should trigger at, or after the timeout value. 2. The watchdog should trigger before twice the timeout value.
Update the watchdog timing requirements: 1. The watchdog should trigger at, or after the timeout value. 2. The watchdog should trigger before twice the timeout value.
Update the watchdog timing requirements: 1. The watchdog should trigger at, or after the timeout value. 2. The watchdog should trigger before twice the timeout value. Remove explicit calls to sleep.
Update the watchdog timing requirements: 1. The watchdog should trigger at, or after the timeout value. 2. The watchdog should trigger before twice the timeout value.
Update the watchdog timing requirements: 1. The watchdog should trigger at, or after the timeout value. 2. The watchdog should trigger before twice the timeout value. Use a SERIAL_FLUSH_TIME_MS value consistent with other tests.
fkjagodzinski
force-pushed
the
test_update-watchdog
branch
from
ad3dab1 to
c1f183b
Compare
adbridge
requested review from
bulislaw and
evedon
and removed request for
rajkan01
bulislaw
approved these changes
Jun 20, 2019
There was a problem hiding this comment.
This looks good.
Not related to this PR @mprse @jamesbeyond I noticed that watchdog HAL heather doesn't follow standard of other updated HAL APIs with listing defined and undefined behaviours (like here https://github.com/ARMmbed/mbed-os/blob/master/hal/sleep_api.h) could you copy it from the docs to the header to match other updated ones.
Add a SPDX license identifier. Add defined & undefined behavior.
|
@bulislaw thanks for the review; I updated the header as requested. |
0xc0170
approved these changes
Jun 25, 2019
|
Ci started to move this forward |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relax the timing requirements for watchdog according to #8857 (comment):
Fixes #8857
Docs update in ARMmbed/mbed-os-5-docs#1088
NOTE: Marking this as a draft -- we should wait until #10777 is merged.Pull request type
Reviewers
@c1728p9 @rajkan01 @jamesbeyond
Release Notes