New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUC472/M453] Support Bootloader and FlashIAP #4008

Merged
merged 8 commits into from Apr 10, 2017

Conversation

Projects
None yet
8 participants
@cyliangtw
Contributor

cyliangtw commented Mar 23, 2017

This PR patches for the targets NuMaker-PFM-NUC472 and NuMaker-PFM-M453 and has the following modifications:

  1. Support Bootloader infrastructure
  2. Support FlashIAP
  3. Support HW AES

Verified OK by mbed-os-example-bootloader and mbed-os-example-bootloader-blinky.
Also passed Greentea test on ARMCC, GCC and IAR, except mbed-os-tests-mbed_hal-flash.
mbed-os-tests-mbed_hal-flash fails due to test code bug itself. See the PR thread below:
#3968
Attached the test report for reference.
M453_GCC_ARM_Test20170323.txt
M453_IAR_Test20170323.txt
M453_ARM_Test20170323.txt
NUC472_GCC_ARM_Test20170323.txt
NUC472_IAR_Test20170323.txt
NUC472_ARM_Test20170323.txt

};
static const flash_algo_t flash_algo_config = {
// FIXME

This comment has been minimized.

@0xc0170

0xc0170 Mar 23, 2017

Member

what does FIXME mean in this file?

This comment has been minimized.

@cyliangtw

cyliangtw Mar 23, 2017

Contributor

Sorry, it's the comment in developing stage. Now, it's redundancy and I removed it.

@0xc0170 0xc0170 requested a review from c1728p9 Mar 23, 2017

@c1728p9

Looks good to me. Excellent work!

@sg-

trng_api.c looks to have some stray tabs and formatting slips. Mind updating? https://docs.mbed.com/docs/mbed-os-handbook/en/latest/cont/code_style/

@0xc0170 0xc0170 added needs: work and removed ready for merge labels Mar 29, 2017

@cyliangtw

This comment has been minimized.

Contributor

cyliangtw commented Mar 30, 2017

It's done to remove stray tabs to avoid formatting slips in trng_api.c .

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 30, 2017

/morph test

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Mar 30, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 30, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1794

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 30, 2017

[NUC472] Fix flash algorithm
1. Remove setting of not released register ICPCON
2. Enable FMC_APUEN to update APROM
@sg-

sg- approved these changes Apr 6, 2017

@sg-

This comment has been minimized.

Member

sg- commented Apr 6, 2017

/morph test-nightly

1 similar comment
@bridadan

This comment has been minimized.

Contributor

bridadan commented Apr 6, 2017

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 6, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1847

All builds and test passed!

@bridadan

This comment has been minimized.

Contributor

bridadan commented Apr 6, 2017

Double ready for merge 😄

@sg- sg- merged commit 1b4a3c3 into ARMmbed:master Apr 10, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test-nightly Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment