New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32F4 Internal ADC channels rework #4152

Merged
merged 1 commit into from Apr 19, 2017

Conversation

Projects
None yet
7 participants
@jeromecoutant
Contributor

jeromecoutant commented Apr 11, 2017

Description

Internal ADC pin are now out of PinMap_ADC array.

This PR is :

Status

READY

STM32F4 Internal ADC channels rework
Internal ADC pin are now out of PinMap_ADC array.
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 11, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 11, 2017

/morph test

@0xc0170 0xc0170 added the needs: CI label Apr 11, 2017

@RobMeades

This comment has been minimized.

Contributor

RobMeades commented Apr 11, 2017

Ref. UBLOX_C030, if it compiles I guess it's good as we're not using the ADCs at the moment.

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 11, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1876

Example Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 11, 2017

restarting test CI as the example failures do not look like valid in this case?

/morph test

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 11, 2017

@marhil01 @tommikas Can you help with Jenkins CI failure (all recent mbed-os PR are red)

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 11, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1877

All builds and test passed!

@tommikas

This comment has been minimized.

Contributor

tommikas commented Apr 11, 2017

@0xc0170 The failing tests have now been disabled while we figure out why they're failing.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 11, 2017

@0xc0170 The failing tests have now been disabled while we figure out why they're failing.

Thanks !

@0xc0170 0xc0170 removed the needs: CI label Apr 11, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 11, 2017

@jeromecoutant I noticed, this is going to the revert branch. I was wondering how this is on top of it, missed that detail previously (please specify destination branch and the intention so its not overlooked, would help).

@0xc0170 0xc0170 changed the base branch from revert-4118-PR_REWORK_INTERNAL_ADC_F4 to master Apr 11, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 11, 2017

I changed the base branch, as we merged the revert commit.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Apr 11, 2017

/morph test

@0xc0170 0xc0170 added the needs: CI label Apr 11, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Apr 11, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1878

All builds and test passed!

@bridadan bridadan added ready for merge and removed needs: CI labels Apr 11, 2017

@sg- sg- merged commit 87610e7 into ARMmbed:master Apr 19, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_ADC_F4_NEW branch Sep 27, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment