Skip to content

HAL I2C: new I2C implementation for Fast Model targets #9013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

HAL I2C: new I2C implementation for Fast Model targets #9013

wants to merge 2 commits into from

Conversation

jamesbeyond
Copy link
Contributor

@jamesbeyond jamesbeyond commented Dec 7, 2018 •
edited
Loading

Description

This the new I2C API implementation for Fast Model targets according to the new I2C HAL API changes
This will PR is for i2c-feature branch and will depend on #8682 merge first.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

cc @scartmell-arm @maciejbocianski

@ciarmcom ciarmcom requested a review from a team December 7, 2018 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Dec 7, 2018

@jamesbeyond, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@cmonr cmonr requested a review from a team December 7, 2018 20:35
0xc0170
0xc0170 reviewed Dec 18, 2018
View reviewed changes
targets/TARGET_ARM_FM/TARGET_FVP_MPS2/i2c_api.c Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 18, 2018

@scartmell-arm Please review

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 16, 2019

@ARMmbed/mbed-os-hal Please review

@cmonr
Copy link
Contributor

cmonr commented Jan 28, 2019

@jamesbeyond This now needs a rebase

@0xc0170
Copy link
Contributor

0xc0170 commented Feb 13, 2019

Please reopen once updated.

@0xc0170 0xc0170 closed this Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

Assignees

No one assigned

Labels

release-version: feature branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jamesbeyond @ciarmcom @0xc0170 @cmonr