Skip to content

Conversation

@davidornelas11
Copy link
Contributor

@davidornelas11 davidornelas11 requested a review from a team as a code owner December 13, 2024 21:29
mlsamuelson
mlsamuelson previously approved these changes Dec 13, 2024
@mlsamuelson
Copy link
Member

mlsamuelson commented Dec 13, 2024

For CASS-4 and CASS-5

context.globals.shouldReload = true;
}, 100);
return () => {
// document.querySelector("body")?.classList.remove("bg-gray-2");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using these to test, but I think we can remove these lines 11 and 16


export default {
title: "Molecules/Cookie Consent",
decorators: [ fullLayoutDecorator ],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are using this in 2 places move decorator to its own file and import it, maybe put it here:packages/unity-bootstrap-theme/.storybook/decorators.js or if we think we will start using it with other packages we can put it in the shared folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think combining these 2 separate stories into the same file works as well. Do you think we should still extract that file into it's own if both stories are in the same file?

Copy link
Contributor

@scott-williams-az scott-williams-az Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they are in the stories are in the same file, no need to create a new file for the decorator at this point

@davidornelas11 davidornelas11 merged commit d3c6110 into dev Dec 20, 2024
1 check passed
@davidornelas11 davidornelas11 deleted the add-cookie-versions branch December 20, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants