-
Notifications
You must be signed in to change notification settings - Fork 9
chore(unity-bootstrap-theme): add cookie consent full screen style #1423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For CASS-4 and CASS-5 |
c4d27ec to
9089670
Compare
| context.globals.shouldReload = true; | ||
| }, 100); | ||
| return () => { | ||
| // document.querySelector("body")?.classList.remove("bg-gray-2"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was using these to test, but I think we can remove these lines 11 and 16
|
|
||
| export default { | ||
| title: "Molecules/Cookie Consent", | ||
| decorators: [ fullLayoutDecorator ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we are using this in 2 places move decorator to its own file and import it, maybe put it here:packages/unity-bootstrap-theme/.storybook/decorators.js or if we think we will start using it with other packages we can put it in the shared folder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think combining these 2 separate stories into the same file works as well. Do you think we should still extract that file into it's own if both stories are in the same file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If they are in the stories are in the same file, no need to create a new file for the decorator at this point
Links
FOR APPROVERS