Skip to content

Conversation

@juanmitriatti
Copy link
Contributor

UDS-1915

Description

Links

FOR APPROVERS

@juanmitriatti juanmitriatti requested a review from a team as a code owner December 16, 2024 21:07

/* Input focus */
input:focus,
textarea:focus,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a side effect with targeting all input elements as it wraps text inputs too
Left = code changes, Right = existing code
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://zeroheight.com/9f0b32a56/p/099ef8-text-input-field/b/07e355 style guide has example matching the right side

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, added special selector

@davidornelas11 davidornelas11 merged commit a8556fb into dev Jan 6, 2025
1 check passed
@davidornelas11 davidornelas11 deleted the UDS-1915 branch January 6, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants