Skip to content

Conversation

@davidornelas11
Copy link
Contributor

Description

add Table story

Links

Copy link
Member

@mlsamuelson mlsamuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing the fixed table variation. We do need to retain the reference for that.

@davidornelas11 davidornelas11 dismissed mlsamuelson’s stale review January 10, 2025 22:36

Added fixed table story

@davidornelas11 davidornelas11 requested a review from a team January 10, 2025 22:36
Copy link
Member

@mlsamuelson mlsamuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I switch to the MD mobile view on the fixed view table, the gradient at the edge of the horizontally scrollable area is off. Is the JS to initialize the fixed area not included or executing? In the pre-consolidation story we have the Javascript tab, which shows this.

Path to the JS file packages/unity-bootstrap-theme/stories/molecules/tables/tables.js

Copy link
Member

@mlsamuelson mlsamuelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm on this that the fix is applied to the React version - looks good. But the Bootstrap version will be like the other stories that require JS, where we'll want to default to the React view.

Also, is the error on the Tables Docs page known and to be resolved elsewhere?

@mlsamuelson mlsamuelson merged commit 61ff716 into component-consolidation Jan 17, 2025
1 check passed
@mlsamuelson mlsamuelson deleted the uds-1878 branch January 17, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants