Skip to content

Fix profile squishing grid view #1448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Fix profile squishing grid view #1448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d8a39aa
fix(app-webdir-ui): fix profile squishing
davidornelas11 Jan 17, 2025
a53688f
fix(unity-bootstrap-theme): fix profile squishing grid view
davidornelas11 Jan 17, 2025
ae13044
docs(app-webdir-ui): add 50% column view storybook
davidornelas11 Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
73 changes: 45 additions & 28 deletions packages/app-webdir-ui/src/WebDirectoryComponent/index.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,11 @@ export default {
control: "select",
options: ["true", "false"],
},
columnView: {
control: "select",
options: ["50%"],
description: "50% mimics the webspark 2 column layout",
},
},
args: { alphaFilter: "false" },
decorators: [story => <FullLayout>{story()}</FullLayout>],
Expand Down Expand Up @@ -40,48 +45,60 @@ const filters = {
export const webDirectoryExampleDepartments = args => {
return (
<div className="uds-content-align">
<WebDirectory
searchType="departments"
deptIds="1349,1353,32397,1518,1520,3534,1350,334996,1504,2000,2003,159390"
API_URL="https://test-asu-isearch.ws.asu.edu"
searchApiVersion="/api/v1/"
filters={filters}
display={{...display, grid: "true"}}
alphaFilter={args.alphaFilter}
// appPathFolder="/my/custom/path/to/component/root/example"
/>
<div className="row">
<div className={args.columnView === "50%" ? "col-md-6" : ""}>
<WebDirectory
searchType="departments"
deptIds="1349,1353,32397,1518,1520,3534,1350,334996,1504,2000,2003,159390"
API_URL="https://test-asu-isearch.ws.asu.edu"
searchApiVersion="/api/v1/"
filters={filters}
display={{ ...display, grid: "false" }}
alphaFilter={args.alphaFilter}
// appPathFolder="/my/custom/path/to/component/root/example"
/>
</div>
</div>
</div>
);
};

export const webDirectoryExamplePeople = args => {
return (
<div className="uds-content-align">
<WebDirectory
searchType="people"
ids="mcrow:454517,mdenke:1350,jagarc50:1350,lhillzev:1353"
API_URL="https://test-asu-isearch.ws.asu.edu"
searchApiVersion="/api/v1/"
display={display}
alphaFilter={args.alphaFilter}
// appPathFolder="/my/custom/path/to/component/root/example"
/>
<div className="row">
<div className={args.columnView === "50%" ? "col-md-6" : ""}>
<WebDirectory
searchType="people"
ids="mcrow:454517,mdenke:1350,jagarc50:1350,lhillzev:1353"
API_URL="https://test-asu-isearch.ws.asu.edu"
searchApiVersion="/api/v1/"
display={display}
alphaFilter={args.alphaFilter}
// appPathFolder="/my/custom/path/to/component/root/example"
/>
</div>
</div>
</div>
);
};

export const webDirectoryExampleDepartmentsAndPeople = args => {
return (
<div className="uds-content-align">
<WebDirectory
searchType="people_departments"
ids=",tgrandli:1344,mcrow:1343,jcunnin8:1358,ccherrer:1358,csmudde:1358"
API_URL="https://test-asu-isearch.ws.asu.edu"
searchApiVersion="/api/v1/"
display={display}
alphaFilter={args.alphaFilter}
// appPathFolder="/my/custom/path/to/component/root/example"
/>
<div className="row">
<div className={args.columnView === "50%" ? "col-md-6" : ""}>
<WebDirectory
searchType="people_departments"
ids=",tgrandli:1344,mcrow:1343,jcunnin8:1358,ccherrer:1358,csmudde:1358"
API_URL="https://test-asu-isearch.ws.asu.edu"
searchApiVersion="/api/v1/"
display={display}
alphaFilter={args.alphaFilter}
// appPathFolder="/my/custom/path/to/component/root/example"
/>
</div>
</div>
</div>
);
};
5 changes: 3 additions & 2 deletions packages/unity-bootstrap-theme/src/scss/extends/_person-profile.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,13 @@ Desktop styles
margin-bottom: 16px;
.profile-img-placeholder {
width: var(--grid-pic-size);
height: var(--grid-pic-size);
height: fit-content;
max-width: 100%;
.profile-img {
width: var(--grid-pic-size);
height: var(--grid-pic-size);
max-width: 100%;
height: auto;
aspect-ratio: 1 / 1;
}
}
}
Expand Down