feat(app-rfi): improve JAWS navigation in country list for phone input #1492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1492/index.html |
mlsamuelson
reviewed
Mar 18, 2025
Member
mlsamuelson
left a comment
mlsamuelson
left a comment
There was a problem hiding this comment.
Is what I'm seeing here, an update to the previous patch so they're consolidated?
I'm trying to figure out how we can maintain this going forward... A good post-scrum discussion.
Contributor
|
Next steps are to add a patches.MD file with info about the patches and links to the relevant PR in react-phone-input-2 package along with the reason why we patched it. Approving this and creating a ticket |
davidornelas11
approved these changes
Mar 18, 2025
Contributor
|
I did not notice an issue before this patch when using macOS voiceover. it read all numbers out loud perfectly. Same as after the patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UDS-1974
Description
Improve accessibility for country list (JAWS)
Links