Skip to content

fix(component-header-footer): point all images to public folder #1495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

fix(component-header-footer): point all images to public folder #1495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed packages/component-header-footer/src/footer/assets/images/endorsedLogo.png
View file
Open in desktop
Binary file not shown.
Binary file removed packages/component-header-footer/src/footer/assets/images/innovationLogo.png
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion packages/component-header-footer/src/footer/components/Innovation/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
import React from "react";

import { trackGAEvent } from "../../../../../../shared";
import innovationLogo from "../../assets/images/innovationLogo.png";
import innovationLogo from "../../../../public/assets/images/innovationLogo.png";
import { FOOTER_URLS } from "../../core/constants";

const DEFAULT_GA_EVENT = {
Expand Down
8 changes: 2 additions & 6 deletions packages/component-header-footer/src/footer/components/Social/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,8 @@ import PropTypes, { shape } from "prop-types";
import React from "react";

import { trackGAEvent } from "../../../../../../shared";
import { getCurrentScriptPath } from "../../../../../../shared/utils";

// @ts-ignore

const currentScriptPath = getCurrentScriptPath();
const endorsedLogo = `${currentScriptPath}assets/images/endorsedLogo.png`;
// @ts-expect-error
import endorsedLogo from "../../../../public/assets/images/endorsedLogo.png";

const DEFAULT_GA_EVENT = {
type: "external link",
Expand Down
3 changes: 1 addition & 2 deletions packages/component-header-footer/src/footer/footer.stories.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import React from "react";

// eslint-disable-next-line import/no-unresolved
import endorsedLogo from "./assets/images/endorsedLogo.png";
import endorsedLogo from "../../public/assets/images/endorsedLogo.png";
import { ASUFooter } from "./footer";

export default {
Expand Down
Binary file removed ...-header-footer/src/header/assets/img/arizona-state-university-logo-vertical.png
View file
Open in desktop
Binary file not shown.
Binary file removed ...component-header-footer/src/header/assets/img/arizona-state-university-logo.png
View file
Open in desktop
Binary file not shown.
Binary file removed packages/component-header-footer/src/header/assets/img/asu-starbucks.png
View file
Open in desktop
Binary file not shown.
Binary file removed packages/component-header-footer/src/header/assets/img/endorsedLogo.png
View file
Open in desktop
Binary file not shown.
Binary file removed packages/component-header-footer/src/header/assets/img/innovationLogo.png
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions packages/component-header-footer/src/header/components/HeaderMain/Logo/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
import React from "react";

import { trackGAEvent } from "../../../../../../../shared";
import vertLogo from "../../../assets/img/arizona-state-university-logo-vertical.png";
import horizLogo from "../../../assets/img/arizona-state-university-logo.png";
import vertLogo from "../../../../../public/assets/img/arizona-state-university-logo-vertical.png";
import horizLogo from "../../../../../public/assets/img/arizona-state-university-logo.png";
import { useAppContext } from "../../../core/context/app-context";
import { LogoWrapper } from "./index.styles";

Expand Down
6 changes: 3 additions & 3 deletions packages/component-header-footer/src/header/components/HeaderMain/Partner/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ import React from "react";

import { trackGAEvent } from "../../../../../../../shared";
// @ts-check
import asuVertLogo from "../../../assets/img/arizona-state-university-logo-vertical.png";
import asuHorizLogo from "../../../assets/img/arizona-state-university-logo.png";
import starbucksLogo from "../../../assets/img/asu-starbucks.png";
import asuVertLogo from "../../../../../public/assets/img/arizona-state-university-logo-vertical.png";
import asuHorizLogo from "../../../../../public/assets/img/arizona-state-university-logo.png";
import starbucksLogo from "../../../../../public/assets/img/asu-starbucks.png";
import { useAppContext } from "../../../core/context/app-context";
import { PartnerLogosWrapper } from "./index.styles";

Expand Down