Skip to content

UDS-1979: fix(unity-bootstrap-theme): added hover white to footer's social icon #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 1, 2025
Merged

UDS-1979: fix(unity-bootstrap-theme): added hover white to footer's social icon #1501

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d855ea1
fix(unity-bootstrap-theme): added hover white to footer's social icon
juanmitriatti Mar 24, 2025
201a77a
fix(component-header-footer): add correct outline for footer links an…
davidornelas11 Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/component-header-footer/src/footer/components/Social/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@ const Social = ({ social: { logoUrl, unitLogo, mediaLinks } }) => {
<FontAwesomeIcon
title="Facebook Social Media Icon"
icon={faFacebookSquare}
className="social-icon"
/>
</a>
)}
Expand All @@ -87,6 +88,7 @@ const Social = ({ social: { logoUrl, unitLogo, mediaLinks } }) => {
<FontAwesomeIcon
title="Twitter Social Media Icon"
icon={faSquareXTwitter}
className="social-icon"
/>
</a>
)}
Expand All @@ -105,6 +107,7 @@ const Social = ({ social: { logoUrl, unitLogo, mediaLinks } }) => {
<FontAwesomeIcon
title="Instagram Social Media Icon"
icon={faInstagramSquare}
className="social-icon"
/>
</a>
)}
Expand All @@ -123,6 +126,7 @@ const Social = ({ social: { logoUrl, unitLogo, mediaLinks } }) => {
<FontAwesomeIcon
title="YouTube Social Media Icon"
icon={faYoutubeSquare}
className="social-icon"
/>
</a>
)}
Expand All @@ -141,6 +145,7 @@ const Social = ({ social: { logoUrl, unitLogo, mediaLinks } }) => {
<FontAwesomeIcon
title="LinkedIn Social Media Icon"
icon={faLinkedin}
className="social-icon"
/>
</a>
)}
Expand Down
15 changes: 13 additions & 2 deletions packages/component-header-footer/src/footer/index.styles.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ const StyledFooter = styled.footer`
font-family: Arial, Helvetica, "Nimbus Sans L", "Liberation Sans", FreeSans,
sans-serif;
line-height: 1.5rem;

a:focus, button:focus {
outline: none;
box-shadow: 0 0 0 2px var(--color-base-white), 0 0 0 4px var(--color-base-grey-7) !important;
}
}

.btn,
Expand Down Expand Up @@ -132,6 +137,12 @@ const StyledFooter = styled.footer`
.nav {
padding-bottom: 1.5rem;

.nav-link .social-icon {
&:hover {
color: var(--color-base-white);
}
}

@media (min-width: 768px) {
padding: 2.5rem 0;
justify-content: flex-end;
Expand Down Expand Up @@ -271,8 +282,7 @@ const StyledFooter = styled.footer`
text-decoration: none;
display: block;

&:hover,
&:focus {
&:hover {
color: var(--color-base-gold);
text-decoration: underline;
}
Expand All @@ -282,6 +292,7 @@ const StyledFooter = styled.footer`
padding: 0;
display: block;
min-height: fit-content;
overflow: visible;
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions packages/unity-bootstrap-theme/src/scss/extends/_globalfooter.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,10 @@ footer {
color: $uds-color-base-gray-4;
line-height: 1;
padding-top: 7px; // Magic number. Reducing the padding by 1px to make the height = 48px.

:hover {
color: $uds-color-base-white;
}
}
}
}
Expand Down