UDS-1992:fix(components-core): added focus css for accordion wrapper #1522
Conversation
|
This should be in unity react core but we should still discuss in standup before |
|
Other accessible accordion examples on the internet do not behave this way (to select the entire group) This must be a misunderstanding of what the ticket intended. I believe this should not be merged. |
Hi @scott-williams-az |
|
Well, I looked at accordions in unity-react-core and we definitely need to update that code to have tab index https://asu.github.io/asu-unity-stack/@asu/unity-react-core/index.html?path=/story/components-accordion--default |
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1522/index.html |
juanmitriatti
changed the title
| margin: 4px; | ||
| width: -webkit-fill-available; | ||
| } | ||
|
|
There was a problem hiding this comment.
This should be removed. change is needed in unity-react-core, not in css
scott-williams-az
left a comment
scott-williams-az
left a comment
There was a problem hiding this comment.
File: AccordionCard.jsx during consolidation The accordion header was add with an a tag. This was incorrect and should have continued to use the button tag. This will restore the focus indicator behavior.
|
@juanmitriatti Pinging you for scotts comment |
|
@davidornelas11 @scott-williams-az This is ready for review again. |
|
Merging this one as I remember you saying you are updating the new accordions to have the button element instead @scott-williams-az |
davidornelas11
dismissed
scott-williams-az’s stale review
Changes are to be made elsewhere
UDS-1992
Description
Checklist
Important Reminders
Links