Skip to content

fix(unity-bootstrap-theme): standardize all list types margins #1527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025
Merged

fix(unity-bootstrap-theme): standardize all list types margins #1527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
345dc84
fix(unity-bootstrap-theme): standardize all list types margins
scott-williams-az Apr 29, 2025
9cccf5e
fix(unity-bootstrap-theme): steplist adjust circle to be more rounded
scott-williams-az May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 13 additions & 17 deletions packages/unity-bootstrap-theme/src/scss/extends/_list.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
--list-padding-top: 0;
--list-padding-right: 0;
--list-padding-bottom: 3rem;
--list-padding-left: 2rem;
--list-padding-left: 3rem;
--list-list-style: none;
--li-before-line-height: 1.5rem;

Expand All @@ -32,6 +32,10 @@
color: var(--li-before-color);
background-color: var(--li-before-background-color);
line-height: var(--li-before-line-height);
left: -3rem;
text-align: right;
position: absolute;
width: 2rem;
}
}
}
Expand All @@ -44,7 +48,6 @@ ul.uds-list ul {
--list-padding-top: 1rem;
--list-padding-right: 0;
--list-padding-bottom: 0;
--list-padding-left: 1.5rem;
--list-list-style: none;
}

Expand Down Expand Up @@ -101,8 +104,6 @@ ul.uds-list,
& > li:before{
--li-before-font-size: 2rem;
vertical-align: middle;
padding-right: 1.25rem; // Magic number.;
margin-left: -2rem;
}
}

Expand Down Expand Up @@ -162,7 +163,6 @@ ul.uds-list {
&.fa-ul {
@include uds-list-spacing;

--list-padding-left: 2.25rem; // Avoid icon clipping.
margin-left: 0rem;
margin-bottom: 0rem;
li .fa-li {
Expand Down Expand Up @@ -197,17 +197,10 @@ ol.uds-list,
& > li:before {
--li-before-font-size: 1rem;
counter-increment: listcounter;
padding-right: .75rem;
margin-left: -1.9rem;
}

// Adjust indent for double digits.
li:nth-of-type(9) ~ li:before {
margin-left: -2.4rem;
}
// Adjust indent for triple digits.
li:nth-of-type(99) ~ li:before {
margin-left: -2.9rem;
left: -3rem;
text-align: right;
position: absolute;
width: 2rem;
}

// Step List styles
Expand Down Expand Up @@ -236,10 +229,13 @@ ol.uds-list,
--li-before-color: #{$uds-color-base-gray-1};
--li-before-font-size: 1.25rem;
border-radius: 50rem;
padding: 0.5rem 0.8rem; // Following is more true to XD step circle sizing, but looks less rounded: padding: 0.4rem 0.6rem;
padding: 0.4rem 0.8rem;
margin-right: 2rem;
margin-left: -4.5rem;
font-weight: bold;
position: absolute;
left: auto;
width: auto;
}
}

Expand Down
22 changes: 20 additions & 2 deletions packages/unity-react-core/src/components/List/List.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,29 @@ const decorator = (story:StoryFn, context: StoryContext) =>
export default {
title: "Components/List",
component: List,
args: {
multiplier: 1,
},
argTypes: {
multiplier: {
name: "Multiplier",
description: "Storybook control - Number of times to repeat the items.",
control: {
type: "number",
min: 1,
max: 111,
step: 1,
},
},
},
decorators: [decorator]
};

const listTemplate = (args: ListProps) => {
return <List {...args} />
const listTemplate = (args: ListProps & { multiplier: number }) => {
const multiplier = args.multiplier > 0 ? args.multiplier : 1;
return (
<List {...args} items={new Array(multiplier).fill(args.items).flat()} />
);
};

export const UnorderedList = {
Expand Down