fix(component-header-footer): fix footer clashing classes with bootsrap JS #1570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidornelas11
force-pushed
the
footer-clashing-classes
branch
2 times, most recently
from
303368d to
0bfa049
Compare
davidornelas11
force-pushed
the
footer-clashing-classes
branch
from
0bfa049 to
59a3d43
Compare
Collaborator
|
Storybook deployed at https://unity-uds-staging.s3.us-west-2.amazonaws.com/pr-1570/index.html |
scott-williams-az
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found when putting the footer in webspark, this issue is caused by clashing class names in the footer. I added footer specific classes for the problematic classes and added a snappier, more responsive column opening. Also, only one column is allowed to be open now so others close when opening more than 1
Checklist