Do not rely on a failure of automatic proof search #321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
Member
|
I tried it with the oldest and newest support coq version and it works, also the change is not that large and I think it would be fairly safe to merge this, what do you think @xavierleroy ? |
Contributor
|
Sorry, I missed this PR initially, and thanks for the ping. The proposed change looks innocuous and is good style anyway. (Normally I try to never use I'll approve and merge ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would like to make “intuition” a bit stronger, in a way that would break this proof script.
See rocq-prover/rocq#11018 for details.